make debugger expand relative paths to absolute #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered issues with setting breakpoints in modules loaded using require, which uses absolute paths.
Using relative paths brings problems in conjunction with the vscode extension, which might find the same file in multiple sourcesRoot directories. Absolute paths would solve this.
debugger class now has a public method set_working_dir, which accepts char*.
If the method is not called, the old behaviour is preserved - relative paths are not expanded.
server class gets cwd in main and handles it to the debugger.
this PR is related to vscode-lrdb PR 13